-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add local storage labels to kube_persistentvolume_info #1814
feat: Add local storage labels to kube_persistentvolume_info #1814
Conversation
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
Maybe it would be best to also add the |
At this point, I wonder if it was really a good idea to add all the FS types to the |
The idea to add specific labels to a dedicated metric seems more than ok to me. Something like:
@dgrisonnet Does it seem ok to you? If so, I can dig to implement it more generic way. |
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
I reverted table changes and add host path labels. |
LGTM, thank you @nabokihms for the contribution :) /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, nabokihms The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yeah your suggestion is pretty similar to what I had in mind, I'll start a github discussion around that topic. |
@dgrisonnet I'd like to participate, if it is possible. |
Signed-off-by: m.nabokikh maksim.nabokikh@flant.com
What this PR does / why we need it:
Local volumes in Kubernetes differ from other volumes, e.g., they do not have the max cap as other persistent volumes. Instead, local PVs can consume all the available space on the disk. Thus, there should be a way to distinguish local PVs (and other rules to monitor them).
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Yes, it make local storage volumes metrics looks like
kube_persistentvolume_info{local_path="/mnt/data", local_fs="ext4"}